Skip to content
This repository was archived by the owner on Aug 5, 2022. It is now read-only.

Conversation

@krocard
Copy link
Contributor

@krocard krocard commented Jun 9, 2015

The Parameter Framework has recently removed (this trick was not working on osx) its *_include libraries. They were used to include headers without linking against the libraries in the android build system.

There is two way to include headers from a library:

  • copy the headers (but that would be in contradiction with how the main pfw headers are included)
  • link against the library (chosen solution)

To avoid linking against a static libxmlserializer - ie add it and its dependency to all plugins - the xmlserializer library is now dynamic.

Link against the dynamic library xmlserializer and no longer use *_include.

@krocard krocard changed the title Do no use _include empty library to include library headers Link to shared library xmlSerializer Jun 9, 2015
@krocard krocard closed this Jun 9, 2015
@krocard krocard reopened this Jun 9, 2015
@krocard krocard force-pushed the remove_include_library_trick branch 2 times, most recently from b97d82b to f94e5fa Compare June 9, 2015 19:09
@krocard
Copy link
Contributor Author

krocard commented Jun 9, 2015

👍

@OznOg
Copy link

OznOg commented Jun 10, 2015

👍

@dawagner
Copy link
Contributor

Same comments on the commit message

@krocard krocard force-pushed the remove_include_library_trick branch 2 times, most recently from 13c51ec to 1bf2252 Compare June 10, 2015 09:48
The Parameter Framework has recently removed
(this trick was not working on osx) its *_include libraries.
They were used to include headers
without linking against the libraries in the android build system.

There is two way to include headers from a library:
 - copy the headers (but that would be in contradiction
   with how the main pfw headers are included)
 - link against the library (chosen solution)

To avoid linking against a static libxmlserializer
- ie add it and its dependency to all plugins -
the xmlserializer library is now dynamic.

Link against the dynamic library xmlserializer and no longer use *_include.

Change-Id: I345f3241b8b3224a075c8e9f19dbf989e6765bd0
krocard added a commit that referenced this pull request Jun 10, 2015
Link to shared library xmlSerializer

The Parameter Framework has recently removed (this trick was not working on osx) its *_include libraries. They were used to include headers without linking against the libraries in the android build system.

There is two way to include headers from a library:
 - copy the headers (but that would be in contradiction with how the main pfw headers are included)
 - link against the library (chosen solution)

To avoid linking against a static libxmlserializer - ie add it and its dependency to all plugins - the xmlserializer library is now dynamic.

Link against the dynamic library xmlserializer and no longer use *_include.
@krocard krocard merged commit 13be58c into master Jun 10, 2015
@krocard krocard deleted the remove_include_library_trick branch June 10, 2015 13:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants